serve-handler icon indicating copy to clipboard operation
serve-handler copied to clipboard

Adds basic auth

Open therebelrobot opened this issue 6 years ago • 6 comments

This PR is aiming to address #60, since there hasn't been much conversation around it yet. I tried to match the error responses as closely as possible to the surrounding code, and am working with a basic config setup of "static": { "auth": [ "username", "password" ] } in the config file itself (I also am opening a PR to zeit/schemas to support this addition, https://github.com/zeit/schemas/pull/54).

Please let me know if additional changes are needed, I'd be happy to address any concerns. Or if this is a "will not fix" kind of issue, please let me know as well. I know for me and my team, though, this would make our lives a lot easier.

Note: I'm pretty sure I got most of the coverage, but again, just working off existing examples, let me know if more is needed. EDIT: found the issue, should be at 100% coverage now

therebelrobot avatar Jul 10 '19 02:07 therebelrobot

Codecov Report

Merging #96 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   99.42%   99.43%   +0.01%     
==========================================
  Files           2        2              
  Lines         345      354       +9     
==========================================
+ Hits          343      352       +9     
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 99.42% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce35fcd...c6da68e. Read the comment docs.

codecov[bot] avatar Jul 10 '19 02:07 codecov[bot]

very nice. :) thank you <3 Let's see when this gets a review

the-architect avatar Jul 22 '19 19:07 the-architect

Hello Zeit :wave:

Any update on this? Our team over here can be using this a lot :) Let me know if I can help in any way to get this merged!

Thanks, Paul

glemmaPaul avatar Dec 02 '19 13:12 glemmaPaul

fwiw, our team would love to have this work as well, so we can lock down internal deployments.

bennidhamma avatar Mar 09 '20 17:03 bennidhamma

This would be a really nice addition for dev environments.

NicholasG04 avatar May 08 '20 15:05 NicholasG04

Any update on this progress?

crimson-med avatar Jul 21 '21 04:07 crimson-med