next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Next codemod bundle with ncc fix ci

Open ishaqibrahimbot opened this issue 3 years ago • 0 comments

This PR seeks to fix the failing CI test in this PR. I'm creating a new PR cause I can't test CI otherwise (can't commit directly to the vercel/nextjs repo). This PR is not yet ready to merge, and carries on from work done by @styfle .

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

ishaqibrahimbot avatar Nov 08 '22 19:11 ishaqibrahimbot

Okay - so exiting and re-entering the directory after running prepare-tests.js seems to have fixed the issue cause CI is passing. Next up - will be investigating exactly what we're doing in prepare-tests.js that is creating this directory issue.

For reference, this was the error: https://stackoverflow.com/questions/53337269/path-js1086-error-enoent-no-such-file-or-directory-uv-cwd

ishaqibrahimbot avatar Nov 09 '22 01:11 ishaqibrahimbot