examples icon indicating copy to clipboard operation
examples copied to clipboard

Edge: disambiguate middleware and edge functions

Open ethomson opened this issue 3 years ago • 2 comments

Description

The Edge Middleware examples were defined in edge-functions, which meant that the Edge Functions examples were defined in edge-api-routes. Update these to their proper names, moving edge-functions -> edge-middleware and edge-api-routes -> edge-functions.

This change also updates the front matter and npm / yarn instructions for demos.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Examples Checklist (@okbel edit)

Example Demo URL Check FrontMatter Layout Example Readme
'ab-testing-google-optimize',
'ab-testing-simple',
'ab-testing-statsig',
'add-header',
'api-rate-limit',
'api-rate-limit-and-tokens',
'basic-auth-password',
'bot-protection-botd',
'bot-protection-datadome',
'clerk-authentication',
'cookies',
'cors',
'crypto',
'feature-flag-apple-store',
'feature-flag-configcat',
'feature-flag-optimizely',
'feature-flag-posthog',
'feature-flag-split',
'geolocation',
'geolocation-country-block',
'hostname-rewrites',
'i18n',
'image-response',
'ip-blocking',
'ip-blocking-datadome',
'ip-manual-blocking',
'json-response',
'jwt-authentication',
'maintenance-page',
'next-news',
'personalization-builder-io',
'power-parity-pricing',
'power-parity-pricing-strategies',
'query-params-filter',
'redirects-upstash',
'rewrites-upstash',
'user-agent-based-rendering'

ethomson avatar Jun 27 '22 21:06 ethomson

@ethomson is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 27 '22 21:06 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
edge-functions-authed-proxy ❌ Failed (Inspect) Jun 28, 2022 at 2:09PM (UTC)
edge-functions-cookies 🔄 Building (Inspect) Jun 28, 2022 at 2:09PM (UTC)
edge-functions-news 🔄 Building (Inspect) Jun 28, 2022 at 2:09PM (UTC)
edge-maintenance-page ❌ Failed (Inspect) Jun 28, 2022 at 2:09PM (UTC)
edge-user-agent-based-rendering ❌ Failed (Inspect) Jun 28, 2022 at 2:09PM (UTC)
i18n ❌ Failed (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-combining-data-fetching-strategies 🔄 Building (Inspect) Jun 28, 2022 at 2:09PM (UTC)
11 Ignored Deployments
Name Status Preview Updated
example-auth-with-ory ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
example-reduce-image-bandwidth-usage ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-image-fallback ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-image-offset ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-loading-web-fonts ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-microfrontends ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-microfrontends-docs ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-pagination-with-ssg ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-reuse-responses ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-script-component-ad ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)
solutions-script-component-strategies ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:09PM (UTC)

vercel[bot] avatar Jun 27 '22 21:06 vercel[bot]

The e2e test suite of edge-function repo (both on PR and scheduled) is pulling some of these examples. Please let the @vercel/edge-compute team know when this will land, so we can adjust our e2e tests (preparation work here)

feugy avatar Dec 08 '22 09:12 feugy

@ethomson This PR can break multiple things as we can't have a proper redirect for the examples that were moved, can we close this PR?

lfades avatar Jan 24 '23 00:01 lfades

We should not break our own links -- we should ensure that we're fixing the marketplace and such, but also, @manovotny has been working to improve the way our examples are displayed and reduce our dependency on GitHub.

We expect that we will break some external links - this has been discussed a few times and: matching our example names with our product names is incredibly important, and solves a real customer problem.

ethomson avatar Jan 24 '23 09:01 ethomson

We can close this PR. I'll be handling it a different way.

manovotny avatar Jan 24 '23 16:01 manovotny