commerce icon indicating copy to clipboard operation
commerce copied to clipboard

Add Ecwid by Lightspeed provider

Open meteor-ec opened this issue 1 year ago • 3 comments

Hi there!

This is Ilnur from the Ecwid by Lightspeed team.

We have added our service as a provider. Please add us to the list.

Thanks a lot!

meteor-ec avatar Feb 27 '24 15:02 meteor-ec

@meteor-ec is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 27 '24 15:02 vercel[bot]

Hey @meteor-ec! This is a good start!

I looked at the changes you made and I have some questions.

  1. The checkout page is very slow and the code for the page is interesting. Is this what you expect users to do? Feels like this could be improved.
  2. Why are you adding <link rel="prefetch" href="/api/revalidate" as="fetch" /> to the <head> in the Layout? What are you trying to do or what does this achieve?
  3. image: product.featuredImage?.url in productJsonLd could produce an invalid schema as it could be undefined. It's be better to change the the model to always return a url, and in lib/ecwid return a default images if there isn't a featured image.
  4. The changes to CartModal for not displaying on the checkout page could be improved. Rearranging the structure of your Layouts or using multiple root Layouts would be the better solve here.

manovotny avatar Mar 20 '24 15:03 manovotny

Hi @manovotny!

Thanks for your review and feedback! I was on vacation and couldn't respond immediately :palm_tree:

So I've made changes to points 2-4, please take a look.

On point 1, we don't have an external url for the checkout page, like Shopify for example. So we embed the checkout into the page. There are plans to improve this place, but for now I decided to leave it as it is.

meteor-ec avatar Apr 19 '24 15:04 meteor-ec

@meteor-ec thanks for making those adjustments.

manovotny avatar May 07 '24 13:05 manovotny

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:31pm

vercel[bot] avatar May 07 '24 13:05 vercel[bot]

Thank you so much @manovotny! :handshake:

meteor-ec avatar May 07 '24 18:05 meteor-ec