python3-krakenex icon indicating copy to clipboard operation
python3-krakenex copied to clipboard

WIP: Retry-on-failure using requests' session adapter

Open veox opened this issue 7 years ago • 0 comments

Incorporates PR #78. After that:

  • Renames the parameters in retry_config:
    • forcelist -> codes
    • retries -> count
    • backoff -> backoff (no change)
  • Greatly limits the default set of error codes to retry on (compared to PR #78): just 504 and 520 now.

This PR:

  • Closes #66 (issue) as implemented.
  • Closes #100 (PR) as conflicting.

I think there might be issues with this approach, though:

  • on every query, the adapter gets re-created - this is rather ungraceful;
  • more importantly, the adapter stays with the session and is used even if retry=False is specified in a follow-up query.

veox avatar Sep 12 '18 22:09 veox