SwiftPasscodeLock icon indicating copy to clipboard operation
SwiftPasscodeLock copied to clipboard

mainWindow's windowLevel should not be changed

Open bull-xu opened this issue 8 years ago • 1 comments

Changing the main window's windowLevel will cause some unexpected issues, such as using the library with Intercom: https://github.com/intercom/intercom-ios because the Intercom window is using windowLevel = 0.1 or some other values.

This library should use a value less than 0 to be the windowLevel for it's private passcodeLockWindow, and never change the windowLevel of the main window.

When presenting the passcodeLockWindow, it's window level can be a bigger number (such UIWindowLevelStatusBar - 1), but once it's dismissed, it should be set back to a number less than UIWindowLevelNormal.

bull-xu avatar May 11 '17 02:05 bull-xu

Sounds good indeed. Thanks for all the info shared. Are you @bull-xu-stride willing to open a PR for this one?

ziogaschr avatar May 25 '17 08:05 ziogaschr