FarmersDelight [1.19.2 Forge 43.1.1] Disconnect upon trying to create and join singleplayer world

Description Whenever I try to create a new world, I get prompted about experimental settings and I press continue. Then I try to generate a world with default settings, but as soon as the generation screen finishes, it kicks me out with a disconnected message to the multiplayer screen. Attempting to join the new world gives a failure to access message before promptly kicking me back to the multiplayer screen.

Steps to reproduce: Having these mods on causes this interaction. Removing Farmer's Delight allows me to create and join a world as normal. I've tried running it without Supplementaries, Canary, Smooth Boot, and DEUF, but the logs and issue remained the same and pointed to this mod.

Expected behavior: For world to be generated with Farmer's Delight and other mods, and allow me to actually join the world.

Logs latest.log

Oct 11 '22 04:10 Rytelus

Hmm... this still sounds like a rogue mod interaction; I was able to test FD in servers before and after release. But nothing in your mod list seems like an obvious target aside from maybe OptiFine.

I suggest running a minimal instance with only FD and nothing else, and seeing if the server lets you log in.

Oct 11 '22 05:10 vectorwing

Thanks for responding so quickly, I followed up on your advice and was able to narrow it down after a few hours. Mind you, this an issue with singleplayer as a minor correction to your statement.

Farmer's Delight and Roughly Enough Resources seem to be the crux of the interaction as the removal of either fixes the issue. If it can't be resolved on your end, should I open an issue on their page?

The mod list now: Cloth Config, Farmer's Delight, REI Plugin Compat, Roughly Enough Items, Roughly Enough Resources. All the same versions as the previous log.

Logs: latest.log rei.log

Oct 11 '22 22:10 Rytelus

Thanks for troubleshooting!

I took a gander at their issues board, and this seems to affect more mods, so there's a chance it's on their end. It seems RER causes errors when placing players if any mod registers a custom loot function. Here's one of the issues: https://github.com/theorbtwo/RoughlyEnoughResources/issues/70

For the time being, all I can suggest is to disable RER until the issue is updated with more info.

Oct 11 '22 22:10 vectorwing

If it helps, the dev of Enigmatic Legacy fixed the same issue on their end in their 1.19.2 branch: https://github.com/Aizistral-Studios/Enigmatic-Legacy/commit/857aa211318873180761aaa01a132a43cb0ac36e

I (hackily) cherry-picked that commit into its 1.18.X branch, and it worked fine. Maybe something similar can be done here?

Mar 07 '23 12:03 unilock

I fixed the issue on the 1.18.2 branch by moving the LootItemFunction registration from CommonSetup#registerLootItemFunctions to a separate class (ModLootFunctions), which allows each class extending LootItemConditionalFunction (i.e. CopyMealFunction, CopySkilletFunction, and SmokerCookFunction) to get its respective LootItemFunctionType, thus appeasing Roughly Enough Resources.

My commit: https://github.com/unilock/FarmersDelight/commit/55436e92ac641c5de5c1e34f94a17fc7c5870467

I don't have much experience with registries, so the way I implemented the fix likely isn't optimal; hence why it's not an outright pull request.

Mar 23 '23 17:03 unilock

@unilock, sorry for the late reply! You were correct, the problem was on FD's end. I mistakenly left getType() as null back then, due to how I was registering the loot functions. It has to be specified, otherwise things break.

Commit 6591911 fixes the issue on 1.18.2, and I'll port it over to 1.19 and 1.20 as well. Thank you for the help! ^^

Jun 23 '23 22:06 vectorwing