emoji-java icon indicating copy to clipboard operation
emoji-java copied to clipboard
verified publisher icon vdurmont

Parses new emojis.json and fix encoding problems

Open Jbwzx opened this issue 5 years ago • 11 comments

This pr:

  1. Adds all available emojis out there
  2. Fix problems with incorrectly encoded emojis e.g:

old emojis.json

    "emojiChar": "🎚",
    "emoji": "\uD83C\uDF9A", // <- wrong

new emojis.json

        "emojiChar": "🎚️",
        "emoji": "\uD83C\uDF9A\uFE0F", // <- correct

Notes:

  1. New db was rebuild using gemoji library database
  2. Old aliases are removed (I wanted to compare and add them, but have no time, sorry)
  3. Tested on Android 5 / 6 / 7 / 8 / 9 / 10 / R all good.

Jbwzx avatar Mar 26 '20 16:03 Jbwzx

I really appreciate the effort! Thanks for working on this. I cannot review in github (the diff is too big and won't load) so I'll try to review later but it looks like it's going to take a looooong time.

I am worried about:

Old aliases are removed (I wanted to compare and add them, but have no time, sorry)

This breaks retrocompatibility. Was it really necessary?

vdurmont avatar Mar 30 '20 17:03 vdurmont

Hey, Thanks for a response.

If it does, I'll compare and add old aliases.

Will update in the next couple of days.

Jbwzx avatar Mar 30 '20 17:03 Jbwzx

@Jbwzx Hi. It also seems like you have lost "supports_fitzpatrick": true in many occasions

alexgasparyan avatar Apr 01 '20 18:04 alexgasparyan

@alexgasparyan just double checked, you're right. will fix alongside aliases. Thanks

Jbwzx avatar Apr 01 '20 18:04 Jbwzx

any updates on this one?

uburoiubu avatar May 12 '20 10:05 uburoiubu

At the very least we can download the json for now and load it manually

MolotovCherry avatar Apr 07 '21 17:04 MolotovCherry

Would be nice to get some updates on this, almost exactly a year later

gdude2002 avatar May 25 '21 09:05 gdude2002

@gdude2002 Funny enough, I've actually put it in my todo list last weekend. I'll try to sort it out in the following fortnight

Jbwzx avatar May 25 '21 09:05 Jbwzx

@gdude2002 ready.

@vdurmont

  1. Gemoji lib reparsed -> Emoji Unicode v13 added
  2. Aliases merged between Emoji-Java and Gemoji
  3. Tags merged between Emoji-Java and Gemoji

and of course as mentioned year ago encoding issue fixed.

Jbwzx avatar May 25 '21 12:05 Jbwzx

Hi

Our team would like to use this latest commits. Is there an ETA where we could get these changes merged?

Thanks

thecatmonkey avatar Jun 15 '21 19:06 thecatmonkey

Hi

Our team would like to use this latest commits. Is there an ETA where we could get these changes merged?

Thanks

Hey.

Not sure re merge, but what we did with one of our commercial project is simply added lib as a submodule replacing reparsed lib file.

Hope this helps.

Jbwzx avatar Jun 15 '21 19:06 Jbwzx