Fix forced disconnect logic

[justinshannon]

Summary by CodeRabbit

• New Features

  • Added more detailed informational logging for key network and hub operations, providing improved runtime visibility for connection and data publishing events.

• Bug Fixes

  • Improved handling of network disconnection events to ensure proper disconnect logic is executed when a disconnection occurs while still marked as connected.

[coderabbitai[bot]]

Walkthrough

This update introduces additional informational logging after key hub operations in both the real and mock ATIS hub connection classes. It also refines the network disconnection handling in the ATIS station view model by conditionally invoking disconnect logic when appropriate, ensuring proper state management during network events.

Changes

File(s)	Change Summary
vATIS.Desktop/Networking/AtisHub/AtisHubConnection.cs	Added informational logging after successful hub method invocations (PublishAtis, SubscribeToAtis, etc).
vATIS.Desktop/Networking/AtisHub/MockAtisHubConnection.cs	Simplified URL construction, improved static log messages, and added detailed logging after hub actions.
vATIS.Desktop/Ui/ViewModels/AtisStationViewModel.cs	Added conditional disconnect logic in OnNetworkDisconnected based on connection status.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AtisStationViewModel
    participant AtisHubConnection

    User->>AtisStationViewModel: Network disconnect event
    alt Status is Connected
        AtisStationViewModel->>AtisStationViewModel: Disconnect() (async)
    end
    AtisStationViewModel->>AtisStationViewModel: Update status, clear data, reset flags

sequenceDiagram
    participant App
    participant AtisHubConnection

    App->>AtisHubConnection: PublishAtis / SubscribeToAtis / GetDigitalAtisLetter / DisconnectAtis
    AtisHubConnection->>AtisHubConnection: Invoke hub method
    AtisHubConnection->>AtisHubConnection: Log.Information after success

Possibly related PRs

• vatis-project/vatis#54: Introduced the GetDigitalAtisLetter method and related DTOs, which are now logged in this PR.
• vatis-project/vatis#200: Enhanced handling of network disconnections and callsign management, directly related to the updated disconnect logic in this PR.

Poem

Logs now bloom where silence lay,
Each hub call leaves a bright new ray.
Connections checked, then safely dropped,
With careful paws, the errors stopped.
A rabbit’s joy: clear trails to see—
Debugging’s now a jubilee!
🐇✨

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.