Refactor RVR parsing

[justinshannon]

Refactor RVR parser and correctly match RVR with missing values

Summary by CodeRabbit

• New Features

  • Added support for displaying runway suffixes (such as L, R, or C) and new indicators for "less than", "greater than", and missing runway visual range (RVR) values in weather reports.

• Refactor

  • Improved the accuracy and clarity of RVR parsing and reporting, resulting in more precise runway visual range information for end-users.

[coderabbitai[bot]]

Walkthrough

The changes refactor the runway visual range (RVR) parsing and description logic. Regex-based parsing is replaced with property-based logic, new properties are added to the RunwayVisualRange entity for suffixes and qualifiers, and the construction of descriptive strings is updated for clarity and maintainability without altering public method signatures.

Changes

File(s)	Change Summary
.../Atis/Nodes/RunwayVisualRangeNode.cs	Refactored to remove regex parsing; now uses RunwayVisualRange properties for description logic.
.../Weather/Decoder/ChunkDecoder/RunwayVisualRangeChunkDecoder.cs	Rewrote regex and parsing logic; improved mapping to new entity properties; streamlined extraction.
.../Weather/Decoder/Entity/RunwayVisualRange.cs	Added public properties: RunwaySuffix, IsMissing, IsLessThan, IsGreaterThan.

Sequence Diagram(s)

sequenceDiagram
    participant Input as RVR String
    participant Decoder as RunwayVisualRangeChunkDecoder
    participant Entity as RunwayVisualRange
    participant Node as RunwayVisualRangeNode

    Input->>Decoder: Provide RVR string
    Decoder->>Decoder: Parse string with new regex
    Decoder->>Entity: Map groups to properties (RunwaySuffix, IsMissing, etc.)
    Decoder-->>Node: Return RunwayVisualRange object
    Node->>Node: Construct description using properties
    Node-->>Output: Output descriptive string

Possibly related PRs

• vatis-project/vatis#238: Refactors RVR tendency handling and spoken output in RunwayVisualRangeNode.cs, which relates to the changes here in descriptive logic and RVR representation.

Poem

A runway’s range, now clear and bright,
No regex maze to parse in fright.
With suffix, flags, and tidy code,
The RVR’s truth is plainly showed.
Hop, skip, and parse—oh what a view!
The weather’s clear, the logic too.
🐇✨

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.