Caret is omitting the runway designator when generating voice ATIS

[neilenns]

Here's my ARPT COND:

CHARTED VISUAL APPROACH RWYS ^16R AND ^16L , APCH IN USE. DEPG RWY ^16L.

The resulting voice ATIS says:

Charted visual approach runways 16 and 16 approach in use. Departing runway 16.

It's omitted the "Left" and "Right" parts of the runway.

vatis version 4.0.0-beta.15

[coderabbitai[bot]]

Walkthrough

The changes introduce a new event handler, OnClosing, in the CompactWindow class, which is registered in the constructor. This handler evaluates the closing event using the WindowClosingEventArgs. If the event is triggered programmatically, the method exits early; otherwise, it cancels the close action by setting the event's Cancel property to true. Additionally, the CompactWindowViewModel class is modified to include a new command for ending the client session and a new dependency for session management.

Changes

File	Change Summary
vATIS...CompactWindow.axaml.cs	Added a private event handler OnClosing to the CompactWindow class. The handler checks IsProgrammatic and cancels the window closing if the event isn't programmatic. Registered OnClosing in the constructor. Updated class declaration to implement IDialogOwner.
vATIS...CompactWindowViewModel.cs	Updated constructor to require ISessionManager. Added EndClientSessionCommand, SetDialogOwner, and HandleEndClientSession methods. Updated Dispose method to include disposal of the command.

Sequence Diagram(s)

sequenceDiagram
    participant W as Window
    participant CW as CompactWindow
    participant E as EventArgs

    W->>CW: Initiate closing event (Constructor registers handler)
    CW->>E: Receive WindowClosingEventArgs
    alt Event is programmatic
        CW->>CW: Return early
        note right of CW: Window closes normally
    else Event is not programmatic
        CW->>E: Set Cancel property to true
        note right of CW: Window closing is prevented
        CW->>CW: Execute EndClientSessionCommand
        alt Command returns true
            CW->>E: Set Cancel property to false
            CW->>W: Close window
        end
    end

Poem

I'm just a rabbit, coding late at night,
Adding a handler with all my might.
When the window's set to close, I take a peek,
If it's not programmatic, I say "no, not yet, please seek!"
Hop along, dear code, with joy so light.
🐇💻

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.