wrong contact freq

[jimihendrix272]

At Heathrow, vATIS instructs pilots to contact Heathrow Director 119.730 for clearance and start, when only the Ground or Tower is on line. Is there a way of editing it? Thanks, John

[coderabbitai[bot]]

Walkthrough

The update refines the logic in the AtisStationViewModel for handling the AtisLetter variable. The methods AcknowledgeOrIncrementAtisLetter and DecrementAtisLetter now use inclusive boundary checks (using ">=" and "<=") to reset the letter when it matches the upper or lower limits of the code range. Increment and decrement operations are executed conditionally based on these checks, ensuring proper wrap-around behavior.

Changes

File Path (shortened)	Change Summary
vATIS.Desktop/Ui/.../AtisStationViewModel.cs	Updated AcknowledgeOrIncrementAtisLetter and DecrementAtisLetter methods by changing boundary checks to inclusive (>= and <=) and moving operations into else blocks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ViewModel
    participant CodeRange
    User->>ViewModel: Call AcknowledgeOrIncrementAtisLetter
    alt AtisLetter >= CodeRange.High
        ViewModel->>ViewModel: Reset AtisLetter to CodeRange.Low
    else 
        ViewModel->>ViewModel: Increment AtisLetter
    end

sequenceDiagram
    participant User
    participant ViewModel
    participant CodeRange
    User->>ViewModel: Call DecrementAtisLetter
    alt AtisLetter <= CodeRange.Low
        ViewModel->>ViewModel: Reset AtisLetter to CodeRange.High
    else 
        ViewModel->>ViewModel: Decrement AtisLetter
    end

Possibly related PRs

• vatis-project/vatis#49: Related through modifications involving the AtisLetter variable; while this PR refines boundary logic in the view model, PR #49 updates the data type of the AtisLetter property in the AtisStation class.

Poem

I'm a rabbit in code, with hops so light,
Twirling through logic in the deep digital night.
Boundaries now inclusive, my steps are clear—
Reset or increment: the pathway is here.
Celebrating smooth loops with a joyful byte!

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f49021fc785a33e1c588055f9fb32f3d7794771 and 8367f922e379c136c339a4fbd9c258bf03c62849.

📒 Files selected for processing (1)

• vATIS.Desktop/Ui/ViewModels/AtisStationViewModel.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: build (macos-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: build (windows-latest)
• GitHub Check: Analyze (cpp)
• GitHub Check: Analyze (csharp)
• GitHub Check: Analyze (csharp)

🔇 Additional comments (2)

vATIS.Desktop/Ui/ViewModels/AtisStationViewModel.cs (2)

1765-1768: Logical fix for proper wrapping at upper bound.

The previous code would have allowed the letter to increment beyond the upper bound before resetting, potentially resulting in an invalid letter during intermediate state. The fix ensures that when the letter reaches the upper boundary, it resets immediately, placing the increment operation in an else clause.

---

1773-1776: Logical fix for proper wrapping at lower bound.

Similar to the increment method, this change ensures that when the letter reaches the lower boundary, it wraps properly to the high value without allowing intermediate invalid values. The decrement operation is now correctly placed in an else clause.

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.