Vasil Dimov

I am ok to drop the test. It is good to have tests to ensure the code works as intended. But we can't have tests for everything and there is...

Concept ACK @MarcoFalke, a bug is a bug, even if it was done on purpose. @jnewbery can clarify here, but I do not think this was even purposeful. My guess...

> > So, what happened? The relaytxes and minfeefilter fields were always present, and documented as such, in the output of the getpeerinfo RPC. > > This isn't true. **None**...

Approach ACK

Having two booleans means we have to deal with all 4 cases: 1. initiator=false, responder=false - meaningless 2. initiator=false, responder=true - ok 3. initiator=true, responder=false - ok 4. initiator=true, responder=true...

Sounds good to use the version for future upgrades - then the `sendtxrcncl` can be expanded/appended with further data as needed. Yeah, the waterfall model where design is followed by...

This is based on the unofficial BIP330 at [naumenkogs/bips](https://github.com/naumenkogs/bips/blob/bip_0330_updates/bip-0330.mediawiki). It would be good to officialize it to [bitcoin/bips](https://github.com/bitcoin/bips/blob/master/bip-0330.mediawiki) before merge. Otherwise we would have the Bitcoin Core disagree with the...

In the OP: * the link to BIP 330 can be updated and this can be removed: "Note this is not what's in the bitcoin/bips repo, but an updated version"....

The newly added test `p2p_sendtxrcncl.py` failed just on "Win64 native" :sob:

> @pmualaba It used to be the default in SC until about 1 year ago when the author suddenly pulled the repo from GitHub without reason. @jondubois what do you...