go

go copied to clipboard

It would be nice to be able to set a Logger on a Service so that errors returned from call handlers can be debugged more easily.

emersion

How do you wait for events as shown in the docs?

9

How do you wait for events as shown in the docs? I can't see anything that take a `context`, so I'm assuming it's missing or built incorrectly? Eg from the...

purpleidea

there isn't anything on the main site or any of the repositories that i'm seeing on how to go from a varlink file to a go package. (I'm assuming a...

james-lawrence

https://github.com/varlink/go/blob/38f589fef6e11cd44a3206a4b6037a8693fef8e1/varlink/connection.go#L298-L304 This doesn't seem to do anything? Each case branch is essentially no-op (contains bare `break`), yet contains no `default` branch which could have implemented validating `protocol` to have valid...

joonas-fi

In this line: https://github.com/varlink/go/blob/38f589fef6e11cd44a3206a4b6037a8693fef8e1/varlink/internal/ctxio/conn.go#L130 bufio.Reader.ReadBytes will continue to read and exhaust available memory without constraints (until the delimiter is read of course), which makes it easy to DoS with: ```...

mdevan

Generators should be rewritten to work with `go generate`

1

Current implementation just uses string formatting, and that is not pretty.

Foxboron