sqlite-nio icon indicating copy to clipboard operation
sqlite-nio copied to clipboard

refactor: Rename CSQLite target to VaporCSQLite to avoid downstream conflicts

Open CrownedPhoenix opened this issue 4 months ago • 4 comments

Due to an issue with SPM and the relative prevalence of C wrappers for SQLite being named CSQLite, it seems prudent/friendly to namespace this target under NIO to reduce the likelihood of target name conflicts with downstream packages.

See: https://github.com/swiftlang/swift-package-manager/issues/8482

I expect this change to be non-breaking and invisible to any downstream packages since it only renames an internal target identifier (not a published product).

CrownedPhoenix avatar Dec 19 '25 22:12 CrownedPhoenix

The medium term plan for this is to remove the dependency on NIO altogether so I'd prefer to have this named VaporSQLite instead

0xTim avatar Jan 02 '26 16:01 0xTim

Why does it matter? We don't expose that target as a linkable product of the package to begin with.

gwynne avatar Jan 02 '26 17:01 gwynne

Why does it matter? We don't expose that target as a linkable product of the package to begin with.

@gwynne See the linked issue in swift-package-manager. There's a bug (?) in SPM that will throw name conflict errors even with targets that are not exposed from downstream modules.

CrownedPhoenix avatar Jan 05 '26 17:01 CrownedPhoenix

The medium term plan for this is to remove the dependency on NIO altogether so I'd prefer to have this named VaporSQLite instead

Made this change.

CrownedPhoenix avatar Jan 05 '26 17:01 CrownedPhoenix