ExplorerPatcher icon indicating copy to clipboard operation
ExplorerPatcher copied to clipboard

New Win11 update (KB5034123) will mess with Win7 Command bar

Open NoNameNeeded5 opened this issue 2 years ago • 12 comments

If you choose to use Win7 Command bar in explorer window, the newest security update (KB5034123) will mess with it.

What happens is that the menu bar will be missing. You can click on organize and select the menu bar again and it will appear again. However, as soon as you close the window and reopen an explorer window, it will be gone again.

NoNameNeeded5 avatar Jan 10 '24 22:01 NoNameNeeded5

Yes, the option to have the "Windows Command Bar (Classic address bar)" no longer works. Address bar is always at the top.

retiredfields avatar Jan 11 '24 00:01 retiredfields

Yes, unfortunately the fix for it doesn't last long as it will make Explorer crash. Moreover, on Dev the feature flag for tabs is now no more :(

I do not know if I can fix this though. Now we're back to the old behavior before the fix. Thankfully they fixed Explorer bringing itself to the front.

Amrsatrio avatar Jan 11 '24 01:01 Amrsatrio

Thanks for the quick reply. I suspected this was the situation.

retiredfields avatar Jan 11 '24 01:01 retiredfields

I don't know what you mean by "now we're back to the old behavior before the fix" but what I mean is that the menu bar "File, Edit etc." will be hidden as soon as you install the above mentioned update. It can be made to show again but the next time you open an explorer window it will be hidden again.

I was actually hoping that this could be fixed. It's not that it's not working at all, it's just hidden by default.

NoNameNeeded5 avatar Jan 11 '24 04:01 NoNameNeeded5

Maybe you're unaware of this issue: https://github.com/valinet/ExplorerPatcher/issues/2243

That issue, as well as your issue, have resurfaced because the Tabs feature flag is no longer here. It's now forced to be enabled and it alters a lot of code even when the old command bar is enabled.

Amrsatrio avatar Jan 11 '24 04:01 Amrsatrio

Oh, I see.

That doesn't sound too good.

But you guys have achieved so much, I'm still hoping that you'll be able to fix this issue too.

NoNameNeeded5 avatar Jan 11 '24 05:01 NoNameNeeded5

Try using oldNewExplorer to patch file explorer instead and see if it achieves what you want.

pyrates999 avatar Jan 11 '24 11:01 pyrates999

I've already tried that but no, it didn't help.

NoNameNeeded5 avatar Jan 11 '24 13:01 NoNameNeeded5

ah ok

pyrates999 avatar Jan 11 '24 14:01 pyrates999

Confirming menu bar disappearance. It is not always hidden (it is quite random), so there should be a way to make it always visible.

Anixx avatar Mar 14 '24 08:03 Anixx

It looks like the menubar 100% can be restored by changing the current color scheme, specifically, windowmetrics, regardless of what the change is.

Could it be that the menu fails to appear and that the background is initially black because the window fails to get the color scheme data? What if one manually forces the window to update the window metric data after creation?

I tried this by sending messages but for some reason it crashes Explorer for me, so I am doing it the wrong way apparently. On the other hand, the color scheme configurators easily make all opened folder windows to have a menu after sending the theme update message.

Maybe we can try to hook the folder window creation and force it to refresh window metrics and colors?

Anixx avatar Apr 18 '24 12:04 Anixx

I have checked it, and my conclusion:

  1. This does not depend on ExplorerPatcher running or not.
  2. It does not depend on the Win7 Command Bar being activated.

Without any EP and with default Win11 Command bar the menubar appears on any Window Metrics change or refresh, for instance, with simple deskn.cpl, the legacy color scheme CP applet.

Anixx avatar Apr 20 '24 12:04 Anixx