validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

docs: fix typos

Open ovarn opened this issue 2 years ago • 1 comments

The README.md file contained a few typos.

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [x] README updated (where applicable)
  • [ ] Tests written (where applicable)
  • [ ] References provided in PR (where applicable)

ovarn avatar Oct 14 '23 21:10 ovarn

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (c25b98f) to head (a730368). Report is 11 commits behind head on master.

:exclamation: Current head a730368 differs from pull request most recent head b541a6e

Please upload reports for the commit b541a6e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2323      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          109      107       -2     
  Lines         2489     2449      -40     
  Branches       628      619       -9     
===========================================
- Hits          2489     2448      -41     
- Partials         0        1       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 14 '23 21:10 codecov[bot]

@ovarn please fix the merge conflicts so we may merge this :)

rubiin avatar Jun 01 '24 16:06 rubiin

I'll try to find the time today or tomorrow. Thanks!

ovarn avatar Jun 02 '24 10:06 ovarn

@ovarn no worries . I fixed them :)

rubiin avatar Jun 02 '24 10:06 rubiin

Looks like it was removed during the merge. When I did this PR, there was no 'uk-UA' in the isTaxID method. But I will fix it now.

ovarn avatar Jun 04 '24 17:06 ovarn

@rubiin what would be the best approach to fix it? Should I revert the merge and do it again? Or should I just add the lang as an another commit?

ovarn avatar Jun 04 '24 17:06 ovarn

since the changes are minor, the best approach is to stash your edits, pull the latest changes and add in your change. That we you wont get a merge conflict as you are working on latest changes

rubiin avatar Jun 05 '24 01:06 rubiin

Thanks! It's done.

ovarn avatar Jun 05 '24 18:06 ovarn