validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

add support for Gibraltar phone numbers

Open tsheaff opened this issue 2 years ago • 2 comments

Per the docs here, telephones in Gibraltar have CC +350 and are 8 digits long.

Checklist

  • [X] PR contains only changes related; no stray files, etc.
  • [X] README updated (where applicable)
  • [X] Tests written (where applicable)
  • [X] References provided in PR (where applicable)

tsheaff avatar Jun 07 '23 02:06 tsheaff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (9ba1735) to head (f5f6c6b). Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2232   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2405           
  Branches      604      604           
=======================================
  Hits         2404     2404           
  Partials        1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 07 '23 02:06 codecov[bot]

Thanks for the contribution, however your regex is too permissive, it allows way more than just mobile phone numbers - check the official ITU document here https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000530007PDFE.pdf

However I am afraid this is has been abandoned completely, so marking it for deletion.

if nothing happens here in a week, I'd close this down

pano9000 avatar Aug 25 '24 15:08 pano9000