validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Added passport number validation for Nigeria (NG) (updated)

Open marvelefe opened this issue 3 years ago • 2 comments

What's inside

  • Added passport number validation for Nigeria (NG)
  • Contains feedback from the initial PR and closes #1891

What I've done

  • Added passport number validation regex for Nigeria (NG) 8362c63fddc5454a717518f78281f746b1e49793
  • Added test for NG passport number validation 8278d24636ed7be75ad96532b68ce5a34417fad8
  • Added 'NG' country code to passport number validation section in README.md a6adeab7d4be541ec1a7dfad266e6e4bc54e7d7b

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [x] README updated (where applicable)
  • [x] Tests written (where applicable)

marvelefe avatar Apr 23 '22 10:04 marvelefe

Codecov Report

Merging #1959 (a94de3e) into master (cfcf911) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfcf911...a94de3e. Read the comment docs.

codecov[bot] avatar May 08 '22 12:05 codecov[bot]

Hello @marvelefe Thank you for your PR ! Mostly LGTM, can you please fix the formatting issues (please check the CI pipeline results) ?

Fixed the formatting issues

marvelefe avatar May 08 '22 12:05 marvelefe