validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard
verified publisher icon validatorjs

isURL is not working as in the version 13.6.0

Open jagadeesh93 opened this issue 4 years ago • 3 comments

Description isURL is not validating some urls which is actually validating in the version 13.6.0

Examples https://www.facebook.com/pages/ABC Bank/455454545454545/ This URL was giving true in version 13.6.0 but in the latest one it is giving false

jagadeesh93 avatar Nov 24 '21 14:11 jagadeesh93

Probably not a bug, as per #1862 and #1866. Introduced in #1751 Please check RFC 2396 to see if it should be a valid URL or not.

WikiRik avatar Nov 24 '21 23:11 WikiRik

@WikiRik Thank you sir , But I have a bunch of facebook urls which has similar of these structure , So how can we ensure a backward compatibility

jagadeesh93 avatar Nov 25 '21 11:11 jagadeesh93

Ah, I read your message wrong. It was true before but false now. The other issues have been the way around. Then this might be a separate issue. Have you tried https://www.facebook.com/pages/ABC%20Bank/455454545454545/ in 13.7.0?

WikiRik avatar Nov 25 '21 11:11 WikiRik

  • https://www.facebook.com/pages/ABC Bank/455454545454545/ returns false (which IMHO is correct, as spaces need to be URL encoded)
  • https://www.facebook.com/pages/ABC%20Bank/455454545454545/ returns true (as the space is now correctly URL encoded)

@jagadeesh93 could you check again here please, if that is OK for you as well, as I otherwise would tend to close this issue.

pano9000 avatar Jan 23 '23 23:01 pano9000

thanks for reporting, but as I haven't received any feedback, I'll close the issue here.

pano9000 avatar Jan 30 '23 19:01 pano9000