Added RegEx for Insta Payment Card and Maestro Cards

Open metajunaid opened this issue 4 years ago • 7 comments

This PR aims to solve issue #1559.

Added regex to validate Maestro and Insta Payment Card.

RegEx Reference taken from: https://gist.github.com/michaelkeevildown/9096cd3aac9029c4e6e05588448a8841 Insta Payment Card: ^63[7-9][0-9]{13}$ Maestro Card: ^(5018|5020|5038|6304|6759|6761|6763)[0-9]{8,15}$

Jul 20 '21 14:07 metajunaid

Codecov Report

Merging #1701 (04525ea) into master (13651ea) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1701   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029

Impacted Files	Coverage Δ
src/lib/isCreditCard.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13651ea...04525ea. Read the comment docs.

Jul 20 '21 14:07 codecov[bot]

Is someone testing this PR?

Jul 23 '21 05:07 metajunaid

I have update the PR with tests in commit https://github.com/validatorjs/validator.js/pull/1701/commits/4a0239f8938dafc98427232add676e98b578c306

Aug 01 '21 16:08 metajunaid

Is some one reviewing this PR?

Aug 07 '21 17:08 metajunaid

@profnandaa , could you take a look on this PR

Aug 18 '21 13:08 metajunaid

Hi @tux-tn, I have resolved the conflicts.

Oct 05 '21 15:10 metajunaid

@metajunaid can you fix the merge conflicts

May 10 '24 10:05 rubiin