vacanza
Add Bhutan holidays
Useful links:
- https://en.wikipedia.org/wiki/Public_holidays_in_Bhutan
- https://www.timeanddate.com/holidays/bhutan/
I would like to work on this issue.
i have gone through all the documentation for holidays in Bhutan and am confident in implementing it.
I have successfully added all the holidays of Bhutan that follow the Gregorian calendar, but I am facing difficulties in adding holidays that follow the lunar calendar. I would appreciate some help with that.
If its lunar calendar holidays aren’t based on any existing calendar systems we’ve already implemented, you might need to implement a custom calendar and calendar group as well for Bhutan. A good reference would be Sri Lanka’s implementation, which was based on external data like https://www.bhutanesecalendar.com/.
If you’re able to figure out how its calendar is calculated, then the Thai calendar and its calendar group might actually serve as better examples.
I noticed that there is a closed PR related to this issue. Should I continue the work based on that PR, or would it be better to start from scratch?
Thanks for your guidance!
I noticed that there is a closed PR related to this issue. Should I continue the work based on that PR, or would it be better to start from scratch?
Thanks for your guidance!
Feel free to reuse the code if you want. Or start from scratch -- whatever works better for you. If you reuse it please make sure to include the original author to CONTRIBUTORS file.
@Prateekshit73 if you aren't comfortable w/ neither of these ideas we can just replace it w/ some different country. Just let us know what you prefer.