vaadin
Update Spreadsheet to POI 4.0
The release vote passed, POI 4.0.0 will be available next week. Most breaking changes are in these quick and easy categories:
- Switch from using int values where Enum is a better fit
- Some method names changed, mostly due to original typos
- If NPOIFS classes were referenced directly, the package has been replaced by POIFS. Won't affect most consumers.
This release also contains some bug fixes, especially one that affected use cases where the same Workbook object underwent multiple edit>save>edit>save cycles [1]. In those cases the saved files after the first save are incorrect/invalid in previous releases. This didn't affect most consumers, who only write or only read a file one time, but projects based on Vaadin-Spreadsheet could easily be affected as it enables real-time editing.
If Vaadin is willing to accept it, I'm willing to take a stab at a compatibility PR. If that works, then I could re-try my major updates to fix all the conditional format bugs/shortcomings and add in full table formatting and document style theme support. I also have a slew of changes that add parsing/support for a much wider range of Excel chart formatting options. These have all been working for a year in our production code, which is starting to become a pure fork at this point, but I'd rather work toward re-unification, if Vaadin plans to continue supporting this product.
[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62130
Greg, Is there any possibility your work solves the problem outlined in #658, trouble with fill indication on touch devices?
I haven't encountered that, as apparently none of our customers using Surface devices have mentioned it. So no, none of my code addresses this.
(edit)
Moved my comments to #658, as they aren't relevant to this discussion.
Sorry there was no answer on this issue lately. I talked privately with @WoozyG and we'll start evaluating the size of the changes required by the update. Once we have a more detailed plan and estimate I will update it here.
I'm also really interested into this issue as the last stable version of Spreadsheet do not seems compatible with POI 3.16+ and contains at least one severe vulnerability : https://app.snyk.io/vuln/SNYK-JAVA-ORGAPACHEPOI-32049 in poi-scratchpad.
In addition, POI 4+ seems to improve performance, security and stability, and can bring compatibility with Java 9+.
I'll try to rebase #701, will also check run some tests with POI 4.1. If everything goes fine we should get a stable version.
Is there any news about this? This issue is two years old now and I really must know if it will be fix eventually. I need to know if I can still use this product or if I must find an alternative. The POI vulnerability has a CVSS Score of 7.5 (among others).