framework icon indicating copy to clipboard operation
framework copied to clipboard

Bundle compatibility client for OSGI

Open chrisnaan opened this issue 4 years ago • 5 comments

Added to maven build to add OSGI manifest entries.

Fixes #11660

Check when you have completed [ x] Valid tests for the pull request [ x] Contributing guidelines implemented

chrisnaan avatar Oct 07 '21 08:10 chrisnaan

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 07 '21 08:10 CLAassistant

Thank you for the contribution.

In the pom.xml line 53 seems to be code formatting issue, perhaps you used tabs instead of spaces.

TatuLund avatar Oct 07 '21 09:10 TatuLund

@chrisnaan Thanks for quick action.

I am curious to know, are you using OSGi with Liferay or Karaf ?

TatuLund avatar Oct 07 '21 10:10 TatuLund

@chrisnaan Thanks for quick action.

I am curious to know, are you using OSGi with Liferay or Karaf ?

We're using Liferay DXP 7.3, we have some legacy Vaadin 7 code we need to get working on Liferay 7.3

chrisnaan avatar Oct 07 '21 10:10 chrisnaan

@TatuLund I don't think this is ready to merge yet, as there are dependencies this module uses that aren't osgi modules either.

chrisnaan avatar Oct 07 '21 11:10 chrisnaan