Browser version/engine parsing error.

[dyorgio]

• Vaadin Framework: 8.5.1

• Web container: Springboot 1.5.12.RELEASE (Embedded Tomcat 8.5.29)

• Description of the bug My production env starts to receive theses logs on this last week. VBrowserDetails cannot parse this user-agent: mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x

Prints on console:

Browser engine version parsing failed for: mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x
Browser version parsing failed for: mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x

• Minimal reproducible example Just send a request to vaadin using mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x as user-agent

• Expected behavior Detect as firefox? over windows xp? Use a logger framework to be possible disable console messages on production.

• Actual behavior Print on System.err trace messages.

[stale[bot]]

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

[javier-godoy]

Hello. Given the error messages, it seems the User-Agent string actually contains the strings rv:x.x.x and firefox/x.x in which case, even if it were detected as firefox over windows xp it would be rejected because it cannot be determined whether the browser is "too old".

The observation about not using a logging framework is valid though.

[stale[bot]]

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!