UXMPDFKit icon indicating copy to clipboard operation
UXMPDFKit copied to clipboard

Fixes and Swift => 4.0 upgrade

Open diegostamigni opened this issue 8 years ago • 7 comments

Hi, I've collected a bunch of fixes from different forks, upgraded the code to swift 4.0 and personally fixed some potential memory leaks with non-weak delegates.

diegostamigni avatar Jan 22 '18 12:01 diegostamigni

Very interesting! Thanks for collecting these @diegostamigni - hope to be able to try out your branch this week or the following. When I do, I'll let you know if there are any weird effects I see.

scottcc avatar Jan 22 '18 16:01 scottcc

Thanks @scottcc, just bear in mind that I've changed the Travis link in the README.md and the git repo URL in the Podspec file.

diegostamigni avatar Jan 22 '18 16:01 diegostamigni

No problem - for stuff we're changing with any regularity at all, we typically point the Podfile reference to a commit SHA instead rather than going the full install-through-cocoapods (not to mention I couldn't push to the official cocoapods repo as I'm not the owner)

scottcc avatar Jan 22 '18 16:01 scottcc

Is there any completion method that returns a array of [UIImage]? This would be great to add.

OscarGorog avatar Jul 24 '18 01:07 OscarGorog

@scottcc love this tool. I know you must be busy. It would be great if you'd merge in some of the pending pull requests.

brianmwadime avatar Oct 01 '18 17:10 brianmwadime

Hi @brianmwadime - glad you like this too. I'm actually not affiliated with uxmstudio in any way (so I can't do any merging). I just happen to like it and use it, like you. I've been on other areas than this project (and don't see that changing for some time) so I'd just suggest you point at @diegostamigni 's repo/branch and see if it helps you out. Hope that helps!

scottcc avatar Oct 01 '18 20:10 scottcc

While you wait this to get merged and made into a release you can directly use @diegostamigni 's fork:

pod 'UXMPDFKit', :git => 'https://github.com/diegostamigni/UXMPDFKit.git'

rivera-ernesto avatar Dec 10 '18 20:12 rivera-ernesto