coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

fix install file with invalid uid

Open zhw2101024 opened this issue 9 months ago • 34 comments

fixes #7879

zhw2101024 avatar Apr 19 '25 11:04 zhw2101024

Could you please add a test to make sure we don't regress? Thanks

sylvestre avatar Apr 19 '25 19:04 sylvestre

Could you please add a test to make sure we don't regress? Thanks

Finished the test.

zhw2101024 avatar Apr 20 '25 05:04 zhw2101024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Apr 20 '25 08:04 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Apr 21 '25 06:04 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Apr 21 '25 10:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Apr 21 '25 14:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Apr 27 '25 07:04 github-actions[bot]

many jobs are failing

sylvestre avatar Apr 27 '25 21:04 sylvestre

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/empty-inacc is no longer failing!

github-actions[bot] avatar Apr 27 '25 22:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Apr 28 '25 04:04 github-actions[bot]

many jobs are failing

Caused by some rebase issues, fixed it now. By the way, the test in this PR need to ensure that there's no user with userid 500 on the system, maybe I can modify the userid in the prepare stage of CICD runners?

zhw2101024 avatar Apr 28 '25 04:04 zhw2101024

I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in /etc/passwd.

jtracey avatar Apr 29 '25 15:04 jtracey

I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in /etc/passwd.

I'm using a long script to get a uid not in /etc/passwd, so adding subprocess to use the Exec::shell method. cat /etc/passwd|cut -d ':' -f 3|grep '^1...$'|sort -n|tail -n 1|awk '{print $1+1}'

zhw2101024 avatar Apr 30 '25 13:04 zhw2101024

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Apr 30 '25 15:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar May 02 '25 09:05 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Jun 24 '25 07:06 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Jun 28 '25 03:06 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-C is no longer failing!

github-actions[bot] avatar Jun 30 '25 09:06 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Jul 05 '25 18:07 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Oct 02 '25 09:10 github-actions[bot]

CodSpeed Performance Report

Merging #7789 will not alter performance

Comparing zhw2101024:test_install_root_combined (ba1dc38) with main (eb80eb0)

Summary

✅ 106 untouched
⏩ 73 skipped[^skipped]

[^skipped]: 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Oct 02 '25 09:10 codspeed-hq[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Oct 19 '25 11:10 github-actions[bot]

@sylvestre Hey, i've added the same logic for invalid gid, and all checks passed. Could this PR be reviewed again?

zhw2101024 avatar Oct 19 '25 11:10 zhw2101024

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Oct 21 '25 00:10 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Oct 21 '25 02:10 github-actions[bot]

@sylvestre Hi, all conversations resolved an all checks passed, please check if the comments are applicable.

zhw2101024 avatar Oct 21 '25 02:10 zhw2101024