coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

``ls``: Changed unwrap_or and ``or`` option handling to lazy evaluated ``unwrap_or_else`` and ``or_else``

Open AnirbanHalder654322 opened this issue 1 year ago • 4 comments

This would help us reduce a lstat() call on ls/colors.rs

AnirbanHalder654322 avatar Aug 02 '24 14:08 AnirbanHalder654322

Nice. How did you detect this?

sylvestre avatar Aug 02 '24 14:08 sylvestre

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Aug 02 '24 14:08 github-actions[bot]

Nice. How did you detect this?

Actually i worked on that part of the code in an old pr, few months back. So i remembered that it was using or instead of or_else there.

AnirbanHalder654322 avatar Aug 02 '24 14:08 AnirbanHalder654322

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Aug 02 '24 15:08 github-actions[bot]

Thanks!

cakebaker avatar Sep 07 '24 13:09 cakebaker