coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

numfmt: add --invalid option

Open sbentmar opened this issue 3 years ago • 10 comments

Implements the --invalid option from issue https://github.com/uutils/coreutils/issues/1280.

sbentmar avatar Dec 31 '22 01:12 sbentmar

Not sure what's causing these failures, it's all passing locally and the failing components are not numfmt :)

sbentmar avatar Dec 31 '22 15:12 sbentmar

Yeah the GNU tests are a bit flaky. No need to worry about it if it's not concerning the util you changed :)

tertsdiepraam avatar Dec 31 '22 16:12 tertsdiepraam

Probably done now, the remaining test failure is not related to this PR :)

sbentmar avatar Jan 02 '23 01:01 sbentmar

I'd forgotten about this PR, I'll have a look at what's causing the failures :)

sbentmar avatar Jun 21 '23 08:06 sbentmar

@sylvestre @tertsdiepraam CI tests are passing again, except for the android thing which doesn't look to be related to this PR :)

The GNU tests related to --invalid are still failing, but they're now failing due to the error message provided not matching instead of the exit code not matching, so that's some kind of improvement. Fixing those error messages (e.g. ! numfmt: invalid suffix in input '4MQ': 'Q' vs ! numfmt: invalid suffix in input: '4MQ') would fix something like 20% of the remaining failures in numfmt.pl. I might look into those failures soon, but in a separate PR.

sbentmar avatar Jun 21 '23 10:06 sbentmar

GNU testsuite comparison:

Skipping an intermittent issue tests/tail-2/inotify-dir-recreate

github-actions[bot] avatar Jun 23 '23 14:06 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/ls/selinux-segfault is no longer failing!
Skipping an intermittent issue tests/tail-2/inotify-dir-recreate

github-actions[bot] avatar Jul 01 '23 15:07 github-actions[bot]

Thanks for your PR :)

cakebaker avatar Jul 01 '23 15:07 cakebaker