Fix improper string formatting

[MMP0]

Some changes to make it more localization-friendly.

---

Examples:

NSLocalizedString and interpolation

In SwiftUI, \( ) interpolation in LocalizedStringKey is automatically formatted with localized formatting-text, but for String it just concatenates strings.

NSLocalizedString("\(sizeString) Drive", comment: "")

This means trying to reference localized strings like: “6 GB Drive”, “32 GB Drive”, “50 GB Drive”, …

Solution

String.localizedStringWithFormat(NSLocalizedString("%@ Drive", comment: ""), sizeString)

Nil-coalescing operator in Text

Text(someObj.optionalString ?? "Empty")

This gives the same result as Text(verbatim: someObj.optionalString ?? "Empty"); “Empty” is also String and is not localized.

Solution

if let str = someObj.optionalString {
	Text(str) // <- String
} else {
	Text("Empty") // <- LocalizedStringKey
}
// or
someObj.optionalString.map { Text($0) } ?? Text("Empty")

LocalizedStringKey cannot be nested with \( ) interpolation

Text("Hello, \("world")!")

“world” is String and is not localized.

Solution

Text("Hello, \(Text("world"))!")