layer_augmentation icon indicating copy to clipboard operation
layer_augmentation copied to clipboard

Code error for n3.py?

Open pangzhan27 opened this issue 5 years ago • 3 comments

Based on your paper, Z1 and Z2 should be connected with disjuntion for this NLI task. However, in n3.py file, it seems that your implement is about conjunction. i don't know if my understanding is correct.

pangzhan27 avatar Jul 14 '20 05:07 pangzhan27

Hey, Thank you for the feedback. The repo is not actively monitored. Sorry about the late response.

We are looking at this issue and will update on this soon.

t-li avatar Aug 05 '20 19:08 t-li

Hey, triple checking the code and the paper, I think it's a typo in the paper. The code is what we did in the experiments. I just submitted a correction request to the ACL anthropology. Here you go (in case you also want to keep track of that): https://github.com/acl-org/acl-anthology/issues/951

t-li avatar Aug 12 '20 20:08 t-li

And we have also updated the arxiv version. FYI.

t-li avatar Aug 25 '20 18:08 t-li