Florian Sager
Florian Sager
@UnveilTech : I tried all 3 implementations with `kinesis.us-east-1.amazonaws.com` and the results look good to me: ``` registered-domain-libs/PHP $ php test-regDomain.php kinesis.us-east-1.amazonaws.com kinesis.us-east-1.amazonaws.com registered-domain-libs/PHP $ php test-regDomain.php test.kinesis.us-east-1.amazonaws.com kinesis.us-east-1.amazonaws.com registered-domain-libs/Perl...
> same issue (s3.amazonaws.com) :( @Pascal76: as `s3.amazonaws.com` is listed in https://publicsuffix.org/list/public_suffix_list.dat and is considered to be a public suffix according to the definition at https://publicsuffix.org/ : _'A "public suffix"...
> There should be a check to avoid NULL for $domPart I just added it in https://github.com/usrflo/registered-domain-libs/commit/ee64e44b0f127892b433e7de4985b7e88179ee80
> $szDom is NULL, it should be "amazonaws.com" $szDom is "kinesis.us-east-1.amazonaws.com" according to the explanation in https://github.com/usrflo/registered-domain-libs/issues/16#issuecomment-1418247938. Maybe it would be more precise to differ between a) registered domain like...
Are you sure you're using the latest implementation? $registeredDomain = getRegisteredDomain("kinesis.us-east-1.amazonaws.com", $tldTree); --> the result in $registeredDomain is "kinesis.us-east-1.amazonaws.com"
> but it should return the master domain "amazonaws.com" instead of "kinesis.us-east-1.amazonaws.com", no ? @UnveilTech : yes, sure. Can you confirm that my explanation for this issue in https://github.com/usrflo/registered-domain-libs/issues/16#issuecomment-1418247938 makes...