userver icon indicating copy to clipboard operation
userver copied to clipboard

yaml_config::YamlConfig should reuse the tests of formats

Open apolukhin opened this issue 1 year ago • 1 comments

yaml_config::YamlConfig has the same interface as formats::*::Value. Reuse the Value tests from https://github.com/userver-framework/userver/tree/develop/universal/src/formats/common/value_test.hpp for yaml_config::YamlConfig the same way as it is done for YAML

https://github.com/userver-framework/userver/blob/4348f91c9251bdfbb596ae68c5c922205b04c8fc/universal/src/formats/yaml/value_test.cpp#L17

Internal ticket: 8685

apolukhin avatar Apr 27 '24 09:04 apolukhin

Looks like it has been already done long time ago: https://github.com/userver-framework/userver/blob/738190a4f0070f683d29399fb47db2246e89d53c/universal/src/yaml_config/yaml_config_test.cpp#L28 by that commit Also, I checked that tests actually instantiate and run for this type, here is output:

$ ./build_debug/universal/userver-universal-unittest --gtest_filter=*YamlConfig*
Running main() from gmock_main.cc
Note: Google Test filter = *YamlConfig*
[==========] Running 53 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 29 tests from YamlConfig/Parsing/0, where TypeParam = userver::v2_8_rc::yaml_config::YamlConfig
[ RUN      ] YamlConfig/Parsing/0.ContainersCtr
[       OK ] YamlConfig/Parsing/0.ContainersCtr (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VectorInt
[       OK ] YamlConfig/Parsing/0.VectorInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VectorIntNull
[       OK ] YamlConfig/Parsing/0.VectorIntNull (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VectorIntErrorObj
[       OK ] YamlConfig/Parsing/0.VectorIntErrorObj (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VectorVectorInt
[       OK ] YamlConfig/Parsing/0.VectorVectorInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VectorVectorIntNull
[       OK ] YamlConfig/Parsing/0.VectorVectorIntNull (0 ms)
[ RUN      ] YamlConfig/Parsing/0.BoostContainerFlatSet
[       OK ] YamlConfig/Parsing/0.BoostContainerFlatSet (0 ms)
[ RUN      ] YamlConfig/Parsing/0.BoostContainerFlatMap
[       OK ] YamlConfig/Parsing/0.BoostContainerFlatMap (0 ms)
[ RUN      ] YamlConfig/Parsing/0.BoostOptionalIntNone
[       OK ] YamlConfig/Parsing/0.BoostOptionalIntNone (0 ms)
[ RUN      ] YamlConfig/Parsing/0.BoostOptionalInt
[       OK ] YamlConfig/Parsing/0.BoostOptionalInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.BoostOptionalVectorInt
[       OK ] YamlConfig/Parsing/0.BoostOptionalVectorInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.OptionalIntNone
[       OK ] YamlConfig/Parsing/0.OptionalIntNone (0 ms)
[ RUN      ] YamlConfig/Parsing/0.OptionalInt
[       OK ] YamlConfig/Parsing/0.OptionalInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.OptionalVectorInt
[       OK ] YamlConfig/Parsing/0.OptionalVectorInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.Int
[       OK ] YamlConfig/Parsing/0.Int (0 ms)
[ RUN      ] YamlConfig/Parsing/0.UInt
[       OK ] YamlConfig/Parsing/0.UInt (0 ms)
[ RUN      ] YamlConfig/Parsing/0.IntOverflow
[       OK ] YamlConfig/Parsing/0.IntOverflow (0 ms)
[ RUN      ] YamlConfig/Parsing/0.UserProvidedCommonParser
[       OK ] YamlConfig/Parsing/0.UserProvidedCommonParser (0 ms)
[ RUN      ] YamlConfig/Parsing/0.ChronoDoubleSeconds
[       OK ] YamlConfig/Parsing/0.ChronoDoubleSeconds (0 ms)
[ RUN      ] YamlConfig/Parsing/0.ChronoSeconds
[       OK ] YamlConfig/Parsing/0.ChronoSeconds (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VariantOk1
[       OK ] YamlConfig/Parsing/0.VariantOk1 (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VariantOk2
[       OK ] YamlConfig/Parsing/0.VariantOk2 (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VariantAmbiguous
[       OK ] YamlConfig/Parsing/0.VariantAmbiguous (0 ms)
[ RUN      ] YamlConfig/Parsing/0.VariantUnambiguous
[       OK ] YamlConfig/Parsing/0.VariantUnambiguous (0 ms)
[ RUN      ] YamlConfig/Parsing/0.TimeOfDayCorrect
[       OK ] YamlConfig/Parsing/0.TimeOfDayCorrect (0 ms)
[ RUN      ] YamlConfig/Parsing/0.TimeOfDayIncorrect
[       OK ] YamlConfig/Parsing/0.TimeOfDayIncorrect (0 ms)
[ RUN      ] YamlConfig/Parsing/0.TimeOfDayNormalized
[       OK ] YamlConfig/Parsing/0.TimeOfDayNormalized (0 ms)
[ RUN      ] YamlConfig/Parsing/0.AsDefaulted
[       OK ] YamlConfig/Parsing/0.AsDefaulted (0 ms)
[ RUN      ] YamlConfig/Parsing/0.TransientParserType
[       OK ] YamlConfig/Parsing/0.TransientParserType (0 ms)
[----------] 29 tests from YamlConfig/Parsing/0 (3 ms total)

... and then other tests passing

pprettysimpple avatar Feb 10 '25 22:02 pprettysimpple