Brendan Baldwin
Brendan Baldwin
What would the testing story be for private state?
Would private state imply there is new support needed for object cloning?
I say this given reliance on proposed ES6 built-ins such as Object.assign https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign
I guess the implementer of the class would need to provide their own mechanism-- but it might be worth promoting a best practice or convention for performing private data propagation...
Adding tests to prove behavior as part of https://github.com/lit/lit/issues/3608
Confirmed fd7d86a50 now in main (thanks, @graynorton) and will be in forthcoming release.
I am definitely in favor of finding a way for Virtualizer to swallow the ResizeObserver loop limit exceeded cases which were caused by observers it constructed. I agree this error...
FWIW this is how we address them in our Virtualizer tests The helper method to ignore them: https://github.com/lit/lit/blob/main/packages/labs/virtualizer/src/test/helpers.ts#L152 How this is used in the test's describe block: https://github.com/lit/lit/blob/main/packages/labs/virtualizer/src/test/scenarios/range-changed-events.test.ts#L19
@akc42 if you come upon a way to trap these ResizeObserver loop limit exceeded errors without hooking window.onerror, I'd be all over it!
@hlmitchell the only way to swallow the errors at the moment are to make changes to window.onerror -- I can provide a convenience method to do so as part of...