spacepackets-py

spacepackets-py copied to clipboard

Packet type (bit 3) and secondary header flag (bit 4) appear to be swapped in your API?

1

@robamu @JakobMeier Hi ~ My understanding per [__the standard__](https://public.ccsds.org/Pubs/133x0b2e1.pdf) is that `packet_type` should correlate to bit three and `sec_header_flag` should correlate to bit four. However, w/ your API it's as...

rogueWookie

Examples

2

Dear @robamu, I have a kind request regarding examples. The code in this repository appears more advanced and feature-rich compared to https://gitlab.com/librecube/lib/python-spacepacket. However, the latter includes some simple examples of...

aafanasyev

Tests are installed as package

4

Currently, the tests are installed as own package and show up in the python environment if the package is installed with pip. Maybe add ```toml [tool.setuptools.packages.find] exclude = ["docs", "tests*"]...

sgaisser

PUS-A standard allows an arbitrary number of bits for this value, but probably the predefined lengths of the UnsignedByteField will be fine for all use cases

lrajer

Missuse of term `subservice` in `PusTm` and `PusTc`

2

`PusTm` (and `PusTc)` use the term `subservice`, to fill in the `PusTcDataFieldHeader`. However, the standard specifies that a `message type identifier` consist of two parts. The following snippets is taken...

borro0