urlchecker-python icon indicating copy to clipboard operation
urlchecker-python copied to clipboard

Clarification on exclude_patterns

Open shyndman opened this issue 4 years ago • 4 comments

Hi there,

I was playing around with your library, and had to dig into your code to see how exclude patterns work. I think I understand correctly that they're substrings (not glob/regex) that can appear in a URL to exclude it from consideration.

Might I suggest that their format and use is clarified in the docs?

shyndman avatar Oct 05 '21 20:10 shyndman

Sure! That would be very helpful! If you’d like to submit a PR I would also be happy to give you credit for a Hacktoberfest contribution.

vsoch avatar Oct 05 '21 20:10 vsoch

Sure, happy to. Give me a few.

shyndman avatar Oct 05 '21 20:10 shyndman

OK, I'm in it. I'm finding a few inconsistencies. Mind if I do a bit of surgery, now that I'm in here?

shyndman avatar Oct 05 '21 23:10 shyndman

go for it!

vsoch avatar Oct 06 '21 00:10 vsoch