cli icon indicating copy to clipboard operation
cli copied to clipboard

Replace space only lines in help with only newline

Open cehoffman opened this issue 5 years ago • 3 comments

What type of PR is this?

  • bug

What this PR does / why we need it:

The changes to automatically indent description text added potential for empty lines that have only the padding text. As a consumer of this library, I have example tests to validate the help text appears as I intend. This was useful in helping to detect the change of description indent between 2.2 and 2.3. However I can no longer use these tests because it would require comment lines with trailing whitespace which is removed with tools like go fmt and goimports.

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

Made an example test with expected output.

Release Notes

(REQUIRED)

NONE

cehoffman avatar Jan 16 '21 12:01 cehoffman

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

stale[bot] avatar Jun 02 '21 15:06 stale[bot]

Closing this as it has become stale.

stale[bot] avatar Jul 04 '21 04:07 stale[bot]

@cehoffman Hello and sorry for the delay and auto-close via stalebot. Are you up for adding a test for this change?

meatballhat avatar Apr 19 '22 23:04 meatballhat

I fixed the issue with trailing whitespace in https://github.com/urfave/cli/pull/1513

@cehoffman can you check that the fix works for you?

abitrolly avatar Dec 02 '22 17:12 abitrolly

Closing

dearchap avatar Dec 03 '22 18:12 dearchap