cli icon indicating copy to clipboard operation
cli copied to clipboard

Convert FilePath field in flags from string to string array

Open kneal opened this issue 5 years ago • 2 comments

Checklist

  • [x] Are you running the latest v2 release? The list of releases is here.
  • [x] Did you check the manual for your release? The v2 manual is here
  • [x] Did you perform a search about this feature? Here's the Github guide about searching.

What problem does this solve?

A clear and concise description of what problem this feature would solve. For example:

  • I am suggesting the FilePath option in all flags should be converted to a string array.

Solution description

A detailed description of what you want to happen.

Today, the FilePath option for all flags is a string. You can use it as an array by doing comma-separated paths within the field. In v1 EnvVar and FilePath were consistent where you could specify an array of environment names separated by commas. I believe the value in converting FilePath to a string array is to maintain consistency for the users setting defaults on the flag options.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Another option I see is leaving it the way it is but one could argue the user experience isn't consistent between setting config for EnvVar and FilePath.

kneal avatar Jul 27 '20 12:07 kneal

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

stale[bot] avatar Oct 27 '20 00:10 stale[bot]

Closing this as it has become stale.

stale[bot] avatar Nov 26 '20 03:11 stale[bot]

@kneal do you have any examples that utilize this behavior? Since this is a breaking change I would likely target for v3

dearchap avatar Oct 17 '22 10:10 dearchap