chat: no option to dismiss 'share private profile?' banner

[jyng]

There's no option to dismiss this if I chose not to share my private profile.

[afknapping]

I would phrase this as "missing functionality to explicitly not share my profile". the banner is just a symptom.

"share private profile?" – yes/no maybe

also: where could i revisit the option once i selected yes or no?

[matildepark]

where could i revisit the option once i selected yes or no?

The core issue! We could gather a lot of this data in our settings store now but I don’t think we got designs for such an interface.

[urcades]

I am here to announce, there were in fact designs, and I will share them:

Will provide something kinder to mobile viewports soon!

[matildepark]

That's not the design we are asking for, @urcades.

where could i revisit the option once i selected yes or no?

[urcades]

@matildepark Ah, gotcha — I was responding directly to the root feedback Jimmy provided.

This is a toggle that should definitely be surfaced in group settings, most likely under the "Participants" section of the group settings:

I'd imagine for consistency-sake, it'd be good to surface this option up in the participant's menu if you happen to click on yourself:

[urcades]

Some of the copywriting between these suggestions needs to be normalized, but I'm working on a settings-wide copy pass for the work Liam is undertaking here.

[philipcmonk]

Not only can you not dismiss this banner, those of us who haven't accepted have endured this alignment for a while now:

[github-actions[bot]]

Stale issue message

[philipcmonk]

This issue needs to be reopened, and i don't see how to do that.

[Fang-]

Because we have this functionality in the group & chat joining screens we can just not show the prompt by default. cc @urcades

[urcades]

@Fang- I 100% agree we should remove this banner wholesale now that we're situating the share optionality where it should've been the entire time.

[urcades]

cc @liam-fitzgerald ^ ^ is this banner an easy thing for us to simply rip out? I believe situating the option to revoke one's "shared private profile" in a group's settings feels stale, esp. given a much-desired update to profile UX, but we should absolutely address the annoying banner asap.