landscape icon indicating copy to clipboard operation
landscape copied to clipboard

chat: "Deleted Message" row element requires "new message"-style spacing, not paragraph spacing

Open urcades opened this issue 4 years ago • 1 comments

Currently, the row elements we use for "deleted messages" looks strange, as though it's a text element belonging to the individual who posted above it. This is largely due to the nature of the element's sizing + its use of 'paragraph' line height:

Screen Shot 2021-11-29 at 8 47 34 AM

Visually, deleted messages should take on the form of an entirely new person posting to a chat, or a new "full" text message row.

A related issue here is that deleted messages don't form elements that can be hovered or interacted with:

https://user-images.githubusercontent.com/1195363/143879951-a0654f13-a68e-41be-9da8-eb2a92b6b743.mov

Apart from the fact that a deleted message is deleted, we should treat them (on the frontend at least) like any other message posted to a chat.

urcades avatar Nov 29 '21 13:11 urcades

I had a go at this, here's the before/after: Screenshot from 2022-04-12 20-03-23 Screenshot from 2022-04-12 20-03-01

What do you guys think? EDIT: cc @urcades @nerveharp

dnmfarrell avatar Apr 13 '22 00:04 dnmfarrell