btc flows shouldn't allow not-master-ticket logins

[rcrdlbl]

Context

Attempting to send a BTC transaction using my Ledger hardware wallet, the UI flow was going great up until I clicked "sign with bridge" and attempted to log in successfully; then was sent to the error page.

Also of note: landscape's ~btc app opened the bridge URL in like 7 new tabs for some reason

Error

1100/X<@https://bridge.urbit.org/static/js/main.6e40c34c.chunk.js:1:25699
p/<@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:365955
G/<@https://bridge.urbit.org/static/js/main.6e40c34c.chunk.js:1:25391
1100/ti<@https://bridge.urbit.org/static/js/main.6e40c34c.chunk.js:1:224982
rs@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3662453
Qo@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3714911
kl@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3702087
Sl@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3702015
Il@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3701876
hl@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3698842
Hi/<@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3648221
t.unstable_runWithPriority@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3725640
zi@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3647998
Hi@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3648168
Qi@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3648101
dl@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3696211
ks@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3667780
o/p<@https://bridge.urbit.org/static/js/main.6e40c34c.chunk.js:1:12414
1100/ti</f<@https://bridge.urbit.org/static/js/main.6e40c34c.chunk.js:1:187974
e/<@https://bridge.urbit.org/static/js/main.6e40c34c.chunk.js:1:258269
c@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3734059
u/a._invoke</<@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3733848
T/</<@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:3734484
r@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:45634
o@https://bridge.urbit.org/static/js/2.5d0ae3f6.chunk.js:2:45838

In Bridge version 2.10.2.

[Fang-]

Hmm, I think this is a duplicate of https://github.com/urbit/bridge/issues/586#issuecomment-871784931. tldr: Bitcoin flow doesn't actually support not-master-ticket logins. I remain unsure about what the correct behavior there would be.

Edit: actually, I guess this is subtly different in that it's about the tx signing flow? Wondering if it'd be sane to support tx signing here using the hardware wallet's built-in Bitcoin support.

[basilesportif]

Yeah, we would need to implement in-browser signing directly in the page or in an extension in order to support this use case. It is something on the roadmap, but browser support for Ledger/Trezor is bad, so it's lower priority.

"Sign with Bridge" is confusing (as we see here) and should be re-messaged or eliminated imo.

[Fang-]

Short of ripping the feature out in its entirety, the short-term thing to do here is just improve the error handling: either prevent the user from using not-master-ticket login methods when they're starting a btc flow, or present a nicer error message/explanation when they do log in.