bridge icon indicating copy to clipboard operation
bridge copied to clipboard

Fix broken Master Ticket process with WalletConnect on L1

Open shawntobin opened this issue 2 years ago • 0 comments

fixes #1124

Changes:

ResetExecute.tsx:

  • Removed the WalletConnect session check from within performReticket and instead now using 2 separate useEffects to ensure correct execution based on wallet type.

useWalletConnect.ts:

  • Removed PeerMeta state variable to reduce some state complexity since this value doesn't need to be returned by the hook anyway. I noticed an issue where it sometimes was showing null where we'd expect it to be set (re-renders setting it to null perhaps?), so rather than put in a fix for that now IMO it's fine to just remove. Deriving from ‘session’ when needed works as expected.

WalletConnect.tsx Metamask.jsx

  • Deleted these components since they’re not being used. Bridge no longer renders a tab screen for Metamask or WalletConnect.

Tested successfully on mainnet with Zerion and Ledger.

shawntobin avatar Nov 06 '23 10:11 shawntobin