bridge icon indicating copy to clipboard operation
bridge copied to clipboard

Bridge has no tests

Open Fang- opened this issue 6 years ago • 2 comments

Obviously problematic! This is already on our radar internally. Let this issue serve as technically discussion for this.

While it would be nice to eventually do render-based testing using a headless browser, @jtobin and I agreed that good first targets for tests would be most things in /lib. Low-level core functionality like transaction signing and key generation need to be consistently correct for Bridge to deliver on what it displays.

Fang- avatar Apr 09 '19 15:04 Fang-

Is there a consensus on a framework of choice for React unit testing? Happy to start on this, if so.

liam-fitzgerald avatar Aug 31 '19 03:08 liam-fitzgerald

We haven't decided on anything yet. For frontend regression testing, jest was brought up as potentially useful, but other than that we haven't discussed this much.

Both azimuth-solidity and urbit-key-generation use Mocha and Chai for unit tests, but idk what special needs a React context would have.

I'm fine with literally anything being done here at all (better than nothing!) but maybe others want a slightly stricter list of requirements. (;
cc @vvisigoth @alexmatz

Fang- avatar Aug 31 '19 12:08 Fang-