sqlalchemy_mptt icon indicating copy to clipboard operation
sqlalchemy_mptt copied to clipboard

Prepare support for SQLAlchemy 2.0

Open philpep opened this issue 3 years ago • 5 comments

Require SQLAlchemy>=1.4 and follow recommended migration path for future SQLAlchemy 2.0: https://docs.sqlalchemy.org/en/14/changelog/migration_20.html

Turn SQLALCHEMY_WARN_20=1 in tests and set PYTHONWARNINGS to always::DeprecationWarning so we get DeprecationWarning displayed during tests.

Fix some contruction which are no longer compatible with SQLAlchemy 2:

  • import declarative_base from sqlalchemy.orm
  • Use table.update().where(...) instead of table.update(...)
  • Use table.delete().where(...) instead of table.delete(...)
  • Drop use of legacy select() with a list argument
  • Drop use of legacy case() with a list argument
  • Use session.get(Model, pk) instead of session.query(Model).get(pk)

philpep avatar Dec 06 '22 14:12 philpep

hello, is this going anywhere?

MeRuslan avatar Mar 11 '23 01:03 MeRuslan

Do you know if you will be able to merged soon ?

corentinclichy avatar Aug 18 '23 15:08 corentinclichy