uploadcare-ruby icon indicating copy to clipboard operation
uploadcare-ruby copied to clipboard

New Gem Architecture, rewrite

Open vipulnsward opened this issue 1 year ago • 1 comments

Description

This PR is a rewrite of the entire gem for version 5. We removed the dependencies with api_struct and rewrote all the API from scratch.

Here are the few additions made:

  • Added Zeitwerk and Faraday for HTTPRequests
  • Wrote all the BaseClients and RestClients from scratch
  • Created user facing Resource classes (Uploadcare::File, Uploadcare::Group etc) that contain all attributes and methods related to the resource (entity)
  • Added configs to resources which can be overridden.
  • Simplified Error Handling

Architecture

The gem follows a very standard structure of Clients for each API and Resources for each structure.

For example:

Uploadcare::File.list is going to trigger the list method from Uploadcare::FileClient and stores the attributes in a PaginatedCollection inside Uploadcare::File Method.

Here's how it looks

|─ lib
│ |─ uploadcare
│ │ |─ clients
| | | |─ file_client.rb
| | | |─ rest_client.rb
| | |─ resources
| | | |─ base_resource.rb
| | | |─ file_resource.rb

For each endpoint, we have a Client class with the method for the endpoint and a Resource class with a method that uses the endpoint.

TODOs

  • [ ] UploadAPI
  • [ ] Configs for UploadAPIs
  • [ ] Missing methods on File to fetch all unpaginated list of files

vipulnsward avatar Dec 11 '24 13:12 vipulnsward

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Dec 11 '24 13:12 coderabbitai[bot]