clean-code-ruby

clean-code-ruby copied to clipboard

hubertjakubiak

Methods should do one thing - one question

1

Hi @uohzxela Thanks for your good contents. It is really helpful. But I have a question about **Methods should do one thing** **Bad:** ``` def email_clients(clients) clients.each do |client| client_record...

wowremywang

I think the local variable in the method split_into_first_and_last_name is different from the one name = 'Ryan McDermott' . So it will not affect the outside name variable's value.

WangZhenhuaFirst

DRY is more prevailing than removing duplicate code.

rocLv

In ruby: ```ruby a = nil || 'a' => 'a' a = false || 'a' => 'a' ```

rocLv

Better example for "Favor functional programming over imperative programming"

1

I don't disagree with the sentiment here, but [Favor functional programming over imperative programming](https://github.com/uohzxela/clean-code-ruby#favor-functional-programming-over-imperative-programming) states that "Functional languages are cleaner and _easier to test_". The test for the example doesn't...

garethrees

Create a separate github organization for the repo?

3

Hi, I really like this repo. I can see it being immensely useful when working on PR reviews in my company. Instead of explaining something I can simply link to...

bruno-