webpackbar icon indicating copy to clipboard operation
webpackbar copied to clipboard

fix: fire done logic when percent is 1, instead of using the compiler "done" hook

Open charlessuh opened this issue 4 years ago • 4 comments

It looks like in webpack@4, the compiler "done" hook sets progress percentage to 1: https://github.com/webpack/webpack/blob/v4.46.0/lib/ProgressPlugin.js#L291-L293 but in webpack@5, there are some additional cache steps that were added such that it doesn't represent progress 1: https://github.com/webpack/webpack/blob/v5.62.2/lib/ProgressPlugin.js#L569-L574

This seems to be cause of https://github.com/unjs/webpackbar/issues/83

charlessuh avatar Nov 09 '21 17:11 charlessuh

@pi0

hewenguang avatar Dec 22 '21 08:12 hewenguang

@pi0 👀

uki1014 avatar Feb 20 '22 23:02 uki1014

@pi0

akijoey avatar Oct 09 '22 12:10 akijoey