fix(connectors): update import to work with esm
๐ Linked issue
Resolves #62
โ Type of change
- [ ] ๐ Documentation (updates to the documentation, readme, or JSdoc annotations)
- [x] ๐ Bug fix (a non-breaking change that fixes an issue)
- [ ] ๐ Enhancement (improving an existing functionality like performance)
- [ ] โจ New feature (a non-breaking change that adds functionality)
- [ ] ๐งน Chore (updates to the build process or auxiliary tools and libraries)
- [ ] โ ๏ธ Breaking change (fix or feature that would cause existing functionality to change)
๐ Description
Updated import statement for "pg" so that is works well with *.mjs files.
๐ Checklist
- [x] I have linked an issue or discussion.
- [ ] I have updated the documentation accordingly.
May I ask when this PR is going to get merged?
can we merge this? need this in a project.
sorry for delay but i need further testing to see either prefer this or import * as syntax (i understand it fixes nitro builds)
in the meantime i suggest to use pnpm patch.
pi0 you have any updates or timeline for when you will look into this?
arg - sorry for accidental click
Hey what are the plans to release this ?
@pi0 what about merge it ?
Any updates on this? Currently having issues with using pg in a nuxt3 project on the nitro side of thingsโsame failure to import: "The requested module 'pg' does not provide an export named 'Client'"
Any updates on this? Currently having issues with using pg in a nuxt3 project on the nitro side of thingsโsame failure to import: "The requested module 'pg' does not provide an export named 'Client'"
Based on what I've seen and read. Yes, pg is unusable until this is fixed. But keep in mind that it is an experimental feature, so it probably has a low priority. Especially since they are in the middle of releasing nitro 3.0, and nuxt is working on nuxt 4.0 Nitro 3.0 was planned for the middle of june or july, so pi0 is likely working that.
I also wanted to use db0 with postgres, but this is blocking me. @pi0 can you help a fellow Passionate Person ๐
Codecov Report
Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
Please upload report for BASE (
main@903e1a0). Learn more about missing BASE report.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/connectors/postgresql.ts | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage ? 29.90%
=======================================
Files ? 15
Lines ? 515
Branches ? 43
=======================================
Hits ? 154
Misses ? 354
Partials ? 7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for fix PR and sorry it got this delayed. db0 was experimental and took less priority. it will get better attention.