retool icon indicating copy to clipboard operation
retool copied to clipboard

Feature request: Option to create dat from removed items

Open zambobway opened this issue 4 years ago • 1 comments

Hi, first I would like to thank you for creating the project :) but was wondering if it would be difficult to create a dat from the removed items? This way I could have compete sets split up ( 1g1r, [removed][others] ).

zambobway avatar Jul 08 '21 18:07 zambobway

It should be easy enough to do. My focus is on refactoring Retool at the moment, but I'll add it as a feature when I get to that part.

unexpectedpanda avatar Jul 08 '21 22:07 unexpectedpanda

I was looking for this too so I've created a fork and made the basic changes for this here. I'm not sure if this fits in with your refactoring plans. If it is something you'd be willing to pull in let me know, at the moment it defaults to always creating a second DAT, would need a bit more work to fit it into your user options - so I didn't submit a pull. I haven't tested too extensively yet will do that as well.

ldolse avatar Jan 22 '23 02:01 ldolse

Awesome stuff, love to see people building on top of the base :)

From this side the feature is built and functioning well in v2, with the options built in as well. The v2 codebase is a radical departure, so future PRs based on v1 aren't likely to gel well. I'm pushing to get v2 out around the end of the month, although since life has a tendency to throw curve balls, I should perhaps hedge that by saying mid-Feb.

unexpectedpanda avatar Jan 22 '23 02:01 unexpectedpanda

Awesome, look forward to V2, I won't try and wrap my head around the user options then, thanks! I'll keep the V2 branch in mind if I want to do other tweaks in the future, I didn't see it until after I'd done the fork.

ldolse avatar Jan 22 '23 02:01 ldolse

Heads up that the v2 branch here is way behind. I work mostly in a private repo then move things across to GitHub. I've only been using the v2 branch here for occasional testing to make sure things are wired up properly.

unexpectedpanda avatar Jan 22 '23 02:01 unexpectedpanda

This is now available in v2.

unexpectedpanda avatar Mar 05 '23 07:03 unexpectedpanda