underworld2 icon indicating copy to clipboard operation
underworld2 copied to clipboard

curvilinear bits 'n pieces

Open julesghub opened this issue 4 years ago • 6 comments

The additions for curvilinear mesh and solving. This PR includes code changes and examples.

Significant code changes in Python and C layer:

  • Make an annulus Mesh, FeMesh_Annulus()
  • Class for defining curvilinear dirichlet conditions, CurvilinearDirichletCondition. (More documentation needed)
  • On every forceVector and stiffnessMatrix there is a rotMat memory chunk
  • Method to immediately force a consistent coordinate system after solve
  • Stokes solve aware of element rotation matrix, ALWAYS use _removeBCs=False

Examples:

  • docs/examples/curvi_examples/ They include simple regression testing.

julesghub avatar Apr 22 '21 04:04 julesghub

Lets schedule a chat for next week to walk over this.

jmansour avatar Apr 22 '21 06:04 jmansour

See examples/curvi_examples for models in annulus geometry. To be merged into master release once the user interface is agreed upon by development team. @julesghub + @jmansour.

julesghub avatar Jul 06 '21 01:07 julesghub

@julesghub do we want to merge this?

rbeucher avatar Nov 25 '21 22:11 rbeucher

What do we want to do with this. It's been a while and we have not discussed it.

rbeucher avatar May 31 '22 01:05 rbeucher

I think we should aim to merge this code in. The interface isn't ideal but the functionality works and is part of Rohan and Thyagi's modeling. Happy to release 2.13 first and then add this functionality in thereafter.

julesghub avatar May 31 '22 01:05 julesghub

Yes, I think we release 2.13 and then we merged into dev.

rbeucher avatar May 31 '22 03:05 rbeucher